Zap Receipts #128
Merged
Zap Receipts #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islandbitcoin
approved these changes
Dec 15, 2025
Contributor
islandbitcoin
left a comment
islandbitcoin
left a comment
There was a problem hiding this comment.
Approved with comments
| image: | ||
| repository: lnflash/flash-pay:0.6.0 | ||
| digest: "sha256:3fb143946096ca58b3e64fb4f9d6562aa060bb356e6bc5c94bcd289e9bcdc8bb" | ||
| repository: lnflash/flash-pay |
Contributor
There was a problem hiding this comment.
will removing the versioning make it look for the "latest" by default?
I think we should be ok if the digest overrides all else.
Collaborator
Author
There was a problem hiding this comment.
No, it'll look for the digest by default. tag: would be it's own field
| else | ||
| echo "Packaging all charts..." | ||
| fi | ||
|
|
Contributor
There was a problem hiding this comment.
Did you mean to leave this code? it seems like debug logging.
Collaborator
Author
There was a problem hiding this comment.
Yes, added intentionally. It updates the Charts var based on cli input, allowing us to build a single package, rather than all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.