-
Notifications
You must be signed in to change notification settings - Fork 17
Showcase orchestrator voting activity in the UI #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Showcase orchestrator voting activity in the UI #457
Conversation
- Introduced a new component to present a list of orchestrators with their voting statistics, including proposals voted on, votes casted, recent votes, and voting turnout.
- Added Cube.js client for data fetching with new utility functions for querying voting history. - Introduced VotingHistoryView component to display voting statistics, including proposals voted on and voting turnout. - Updated package.json and pnpm-lock.yaml to include Cube.js client dependencies.
- Exported VoterSummary type for better type management in voting components. - Integrated VotingHistoryView into the account layout for displaying voting statistics. - Added new VotingHistory page to handle routing and data fetching for user voting history. - Updated account layout to include a new tab for voting history, improving user navigation. - Implemented utility functions for processing and summarizing voting data from Cube.js.
- Added OrchestratorVotingList component to display voting data for orchestrators. - Implemented tabbed interface for Yield Overview and Voting History sections. - Integrated voter summary processing functions to aggregate voting data. - Updated getStaticProps to fetch and pass initial voter data to the page.
- Adds treasury proposals voting overview
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
894848d to
3e5ac11
Compare
- Changed the method of accessing raw data from Cube.js API to use a function call. - Simplified response validation in getStaticProps by removing unnecessary checks and directly using the response for voter summaries.
- Fetches voting metrics (voted/eligible) from Cube.js using LivepeerVoteProposals - Adds an interactive Stat card to OrchestratingView with a visual progress bar - Displays participation rate percentage and integrated link to account history - Adds utility to the Cube query generator
…nology - Moved to a friendlier "Sky & Tomato" color scheme to keep voting separate from our main green brand accent. - Standardized labels to "For / Against / Abstain" everywhere, including the global transaction feed. - Rebuilt the vote table using our core data table component for a consistent look. - Made it easier to explore voter history with new dedicated buttons, better tooltips, and subtle animations. - Cleaned up the layout by stripping out redundant titles and shrinking fonts where they were getting too loud. - Polished the details: added specific styling for "No reason provided" and refined how voter profiles are we showing voter names and txn links.
- Eliminated the agent log useEffect that was posting debug information. - Streamlined imports by removing unnecessary useEffect import.
…List - Changed badge colors to use a "Sky & Tomato" color scheme for better visual distinction. - Updated badge labels from "Yes/No" to "For/Against" to standardize terminology across the application.
rickstaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jipperism, @thebeyondr, @ECWireless great to see this is ready for review. 🎉
rickstaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jipperism I noticed the treasury vote is not showing up correctly in the transaction widget.
|
@Jipperism can we add a spinner instead of the
|
rickstaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamsoffer, @hthillman would it make sense to make the mobile pagination styling here similar as the ones on the mainpage or does the difference make sense since we have a subwidget?
Voting mobile pagination
Main page mobile pagination
rickstaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamsoffer, @hthillman would be great to get your input on the double boarder strucutre in the voting widget. Do yout hink this prefered or we should make it consistent with the other widgets.
Voting widget:
Other widgets:
rickstaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jipperism, @thebeyondr love the voting history popup. One thing I noticed is that it shows 0.00LP next to each vote.
rickstaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jipperism I noticed that for some reason votes are showing duplicate but with no title in the history tab. See https://explorer-arbitrum-one-git-310-showca-05d537-livepeer-foundation.vercel.app/accounts/0x5d98f8d269c94b746a5c3c2946634dcfc75e5e60/history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jipperism @thebeyondr looks like formatting of the orchestrator widget on the homepage is broken in this pull request.
Screen_Recording_20260113_160117_Brave.mp4
…ails Implement a new TreasuryVoteEvent component to fetch and display information about treasury vote events, including voting support and proposal titles. Update TransactionsList to render this component for relevant events.
Addressed in 18ca7dd |
…ing state management Refactor the VoteTable component by extracting the vote fetching logic into a custom hook, `useVotes`, to improve code organization and reusability. Enhance loading state management for votes and treasury vote events, ensuring a smoother user experience during data fetching.
Addressed in d3272cd |
…onents Enhance VoteDetail and VotePopover components by introducing a formatWeight prop for consistent weight formatting across the voting UI. This change improves the flexibility of weight display and maintains a unified presentation of voting data.
Addressed in 437236a |
…prove title trimming Update variable names for treasury vote events for consistency and clarity. Enhance the rendering of event titles by trimming whitespace to improve presentation in the UI.
Addressed in 443921f |
…tors Change text colors for For and Against labels to match their respective vote indicators. Update border radius for progress bars in the TreasuryVotingWidget and VotingWidget components to create a more modern, rounded appearance.





Description
Surface orchestrator governance activity so stakeholders can see how they vote over time and per proposal.
Type of Change
Related Issue
Closes #310
Closes #464
xxx## Changes Made
Governance visibility (core of #310)
Voting Widget Formatting (fixes #464)
SectionLabel) and layout.Refactors
Fixes
Testing
Screenshots (if applicable)
Checklist