Skip to content

fix: use DisableCloseByDTLS, close and recreate PCs on retry #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anunaym14 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −10
Open

fix: use DisableCloseByDTLS, close and recreate PCs on retry #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,19 +321,19 @@ func (e *RTCEngine) configure(
}

if e.publisher != nil {
setConfiguration(e.publisher, configuration)
} else {
if err := e.createPublisherPCLocked(configuration); err != nil {
return err
}
e.publisher.Close()
e.publisher = nil
}
if err := e.createPublisherPCLocked(configuration); err != nil {
return err
}

if e.subscriber != nil {
setConfiguration(e.subscriber, configuration)
} else {
if err := e.createSubscriberPCLocked(configuration); err != nil {
return err
}
e.subscriber.Close()
e.subscriber = nil
}
if err := e.createSubscriberPCLocked(configuration); err != nil {
return err
}

return nil
Expand Down
1 change: 1 addition & 0 deletions transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ func NewPCTransport(params PCTransportParams) (*PCTransport, error) {
if len(params.DTLSEllipticCurves) > 0 {
se.SetDTLSEllipticCurves(params.DTLSEllipticCurves...)
}
se.DisableCloseByDTLS(true)
Copy link
Copy Markdown
Member Author

@anunaym14 anunaym14 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches server behavior: livekit/livekit@c76fb0b#diff-5c2446a24723d589881637c71008cafa7e3c16159fee094a8ab028eb2a5638bcR288-R291

se.SetDTLSRetransmissionInterval(dtlsRetransmissionInterval)
se.SetICETimeouts(iceDisconnectedTimeout, iceFailedTimeout, iceKeepaliveInterval)
lf := pionlogger.NewLoggerFactory(logger)
Expand Down
Loading