Fix data race contributing to wrong value of ended_at#868
Merged
Conversation
Fix `endedAt == startedAt` (zero duration) when all tracks are removed before `Synchronizer.End()` is called. This is a race in the egress shutdown path: track workers call `RemoveTrack` (which deletes from `p.tracks`) before the pipeline calls `End()`. When `End()` iterates participants to find `maxPTS`, the tracks map is already empty, so `maxPTS = 0` and `endedAt = startedAt`. The bug was latent before the duration inflation fix but masked by `time.Now()` fallback.
boks1971
approved these changes
Mar 25, 2026
| defer p.Unlock() | ||
|
|
||
| if t := p.tracks[ssrc]; t != nil { | ||
| t.Lock() |
Contributor
There was a problem hiding this comment.
can we make this an API call to TrackSynchronizer. Would be good to keep locking inside that struct and just return the value.
milos-lk
added a commit
to livekit/egress
that referenced
this pull request
Mar 25, 2026
milos-lk
added a commit
to livekit/egress
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
endedAt == startedAt(zero duration) when all tracks are removed beforeSynchronizer.End()is called.This is a race in the egress shutdown path: track workers call
RemoveTrack(which deletes fromp.tracks) before the pipeline callsEnd(). WhenEnd()iterates participants to findmaxPTS, the tracks map is already empty, somaxPTS = 0andendedAt = startedAt.The bug was latent before the duration inflation fix but masked by
time.Now()fallback.