Skip to content

Prepare package configurations for publishing.#478

Merged
xStrom merged 7 commits intolinebender:mainfrom
xStrom:toml
Mar 1, 2024
Merged

Prepare package configurations for publishing.#478
xStrom merged 7 commits intolinebender:mainfrom
xStrom:toml

Conversation

@xStrom
Copy link
Member

@xStrom xStrom commented Mar 1, 2024

I went over all the Cargo.toml files to get them ready for the upcoming publishing.

  • Enabled publish for vello itself.
  • Bumped vello version to 0.1.0.
  • Removed the workspace version. Every published crate gets its own dedicated version, which for now only means vello & vello_encoding.
  • Added rust-version to document the reality of 1.75 being needed to compile vello at this moment.
  • Excluded some needless files from being bundled when publishing, which is going to reduce the size of the published package by ~1MB !!
  • Promoted some dependencies to workspace dependencies.
  • Reordered some properties to get them into consistent order in all files.

Copy link
Member

@xorgy xorgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I would like that one added comment and clarification on the MSRV.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks reasonable

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - these are useful improvements

@xStrom xStrom mentioned this pull request Mar 1, 2024
Copy link
Member

@xorgy xorgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants