Conversation
|
Rendered links: |
|
Uuuugh. Clippy thinks "PostScript" is a doc item. |
raphlinus
left a comment
There was a problem hiding this comment.
I did a medium-depth pass, and am publishing my review now so we can keep velocity. I might have more comments later. In any case, I think it's pretty solid overall and will be very helpful to people coming to the repo. Thanks!
DJMcNab
left a comment
There was a problem hiding this comment.
I've only skimmed through the architecture document, but it's good to get one added.
Otherwise, some parts of the readme which I think could be clarified further
Update README.md Add ARCHITECTURE.md
495791d to
da35091
Compare
|
(Sorry everyone, I rebased from master and ended up doing a force push. My corrections from feedback are in the third commit.) |
| > - [Major rendering artifacts when drawing more than 64k objects](https://github.com/linebender/vello/issues/334). | ||
| > - [Implementing blur and filter effects](https://github.com/linebender/vello/issues/476). | ||
| > - [Properly implementing strokes](https://github.com/linebender/vello/issues/303) and [supporting all SVG stroke caps](https://github.com/linebender/vello/issues/280). | ||
| > - [Conflations artifacts](https://github.com/linebender/vello/issues/49). |
There was a problem hiding this comment.
I really should update this bug, as conflation artifacts within a path are fixed now, if you select multisampled rendering. Of course, conflation in compositing (a considerably harder problem) is still open.
|
I think everyone's feedback is addressed. Will merge this today unless there's some egregious problem. Any further tweaks will happen in a future PR. |
xStrom
left a comment
There was a problem hiding this comment.
Nice work, great to see the docs improving like this! 🚀
Update README.md
Add ARCHITECTURE.md