Test implicit vs explicit chromatic adaptation #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcur
commented
Apr 16, 2025
Member
Author
tomcur
left a comment
tomcur
left a comment
There was a problem hiding this comment.
(Perhaps the test above this one is now a bit superfluous, though it doesn't do exactly the same thing. Probably it doesn't hurt to keep.)
raphlinus
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to test the current implementation of absolute conversions (added in #139), but the main motivation is to have tests in place as preparation for manual implementations of
ColorSpace::{to_linear_srgb_absolute, from_linear_srgb_absolute}for the non-D65 color spaces.