Add absolute conversion matrices for ProPhoto RGB #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
approved these changes
Apr 24, 2025
Collaborator
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
Assuming the tests validate that the matrix values are correct, looks good to me.
Member
Author
They do, but can't catch small errors. |
tomcur
added a commit
that referenced
this pull request
Apr 24, 2025
Continuing the addition of absolute color conversion matrices. See also #156.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
Continuing the addition of absolute color conversion matrices. See also #156.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
Continuing the addition of absolute color conversion matrices. See also #156.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #139, which added absolute color conversions (conversions without chromatic adaptation). The default method implementations added there use the chromatically-adapting methods and undo adaptation through additional matrix multiplies. For efficiency, we can do the absolute conversions using matrices that do not include adaptation in the first place.
This PR does that for ProPhoto RGB. More to follow.