Skip to content

feat: Handle offline mode in Flagship app#2186

Merged
Ldoppea merged 13 commits intomasterfrom
feat/offline
Feb 12, 2025
Merged

feat: Handle offline mode in Flagship app#2186
Ldoppea merged 13 commits intomasterfrom
feat/offline

Conversation

@Ldoppea
Copy link
Copy Markdown
Contributor

@Ldoppea Ldoppea commented Sep 19, 2024 •
edited
Loading

We want cozy-home to be compatible with the new Flagship app's Offline mode

When hosted in a Flagship app's WebView we now want to use FlagshipLink instead of StackLink in cozy-client

This link will allow to redirect all queries to the Flagship app that will handle data access when offline but also when online

Related PR: linagora/cozy-client#1507
Related PR: linagora/cozy-flagship-app#1239
Related PR: linagora/cozy-libs#2562
Related PR: linagora/cozy-libs#2581
Related PR: linagora/cozy-libs#2585

### ✨ Features

* Add support for Offline mode in Flagship app

### 🐛 Bug Fixes

*

### 🔧 Tech

*

TODO:

@bundlemon
Copy link
Copy Markdown

bundlemon bot commented Sep 19, 2024 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ vendors/home.(hash).js
 1.81MB (+8.91KB +0.48%) -
✅ intents/home.(hash).js
 25.91KB (+99B +0.37%) -
✅ app/home.(hash).js
 48.62KB (-117B -0.23%) -
Unchanged files (10)
Status Path Size Limits
✅ services/softDeleteOrRestoreAccounts/home.js
 466.15KB -
✅ services/updateAccounts/home.js
 463.29KB -
✅ services/deleteAccounts/home.js
 311.95KB -
✅ services/myselfFromIdenties/home.js
 236.35KB -
✅ services/polyfillFetch/home.js
 97.38KB -
✅ vendors-home.(hash).(hash).min.css
 38.02KB -
✅ services/attributesHelpers/home.js
 15.22KB -
✅ app-home.(hash).min.css
 1.96KB -
✅ intents/index.html
 651B -
✅ intents-home.(hash).min.css
 158B -

Total files change +8.89KB +0.25%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

Ldoppea added a commit to linagora/cozy-client that referenced this pull request Sep 19, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
54d8680 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: linagora/cozy-home#2186
@Ldoppea Ldoppea mentioned this pull request Sep 19, 2024
Merged
Ldoppea added a commit to linagora/cozy-client that referenced this pull request Sep 19, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
05641b0 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: linagora/cozy-home#2186
Ldoppea added a commit to linagora/cozy-client that referenced this pull request Sep 19, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
cf2a800 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: linagora/cozy-home#2186
Ldoppea added a commit to linagora/cozy-client that referenced this pull request Sep 23, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
2fcf290 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: linagora/cozy-home#2186
Ldoppea added a commit to linagora/cozy-client that referenced this pull request Sep 23, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
ecb276d 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: linagora/cozy-home#2186
Ldoppea added a commit to linagora/cozy-client that referenced this pull request Sep 24, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
0bee9ae 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: linagora/cozy-home#2186
This was referenced Sep 24, 2024
Merged
Merged
Ldoppea added a commit to linagora/cozy-client that referenced this pull request Sep 24, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
6f23dbe 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: linagora/cozy-home#2186
Ldoppea added a commit to linagora/cozy-client that referenced this pull request Sep 24, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
374782f 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: linagora/cozy-home#2186
paultranvan
paultranvan reviewed Jan 29, 2025
View reviewed changes
Comment thread manifest.webapp
@Ldoppea Ldoppea force-pushed the feat/offline branch 2 times, most recently from cd96ab4 to ab7e80b Compare February 6, 2025 18:25
paultranvan
paultranvan approved these changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@paultranvan paultranvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Ldoppea and others added 9 commits February 12, 2025 11:42
@Ldoppea @paultranvan
refactor: Use useSettings hook in DefaultRedirectionSnackbar
2b5597e 
In linagora/cozy-client#1460 we implemented a new `useSettings` hook

This hook can be used in `DefaultRedirectionSnackbar` in order to
simplify code and homogenize the way we access cozy-apps settings
@Ldoppea @paultranvan
refactor: Rename helper to useShouldShowDefaultRedirectionSnackbar
eb31ed2
@Ldoppea @paultranvan
feat: Handle offline mode in Flagship app
2926941 
We want cozy-home to be compatible with the new Flagship app's Offline
mode

When hosted in a Flagship app's WebView we now want to use FlagshipLink
instead of StackLink in cozy-client

This link will allow to redirect all queries to the Flagship app that
will handle data access when offline but also when online

Related PR: linagora/cozy-client#1507
Related PR: linagora/cozy-flagship-app#1239
@Ldoppea @paultranvan
fix: Do not rely on .attributes from queries result
f676669
@Ldoppea @paultranvan
fix: Use a query for fetchAllKonnectors()
170cf06
@Ldoppea @paultranvan
feat: Declare offline compatibility in manifest.webapp
ae10084
@Ldoppea @paultranvan
feat: Rename FlagshipLink to WebFlagshipLink
3ed06b1 
Related PR: linagora/cozy-client#1536
@paultranvan
feat: Make dataproxy available for RN env
155d978
@paultranvan
fix: Prevent infinite loop at startup
f7eb952 
At startup we check some "app highlights" status, typicallky for backup
or geolocation tracking.
In the tracking case, we need to query the database in order to check if
there is some geolocation data.
This query might fail in offline if the local database is not ready.

And this failure was causing an infinite loop, because a retry was made
for each failed query.
paultranvan and others added 2 commits February 12, 2025 11:42
@paultranvan
refactor: Links should be array
93971dc
@Ldoppea @paultranvan
feat: Upgrade cozy-dataproxy-lib to 3.4.1
e7f9258 
`cozy-dataproxy-lib` has been upgraded to `3.4.1` in order to retrieve
a fix on the Assistant icon that would not be displayed on Flagship app
in offline mode

Related PR: linagora/cozy-libs#2732
Ldoppea and others added 2 commits February 12, 2025 11:51
@Ldoppea
feat: Add cozy-pouch-link to dependencies
4317e81 
Since linagora/cozy-libs#2711 `cozy-pouch-link` is now a peer-dependency of
cozy-dataproxy-lib

So we want to add it to cozy-home

However it won't be used in the cozy-home context, we may want in the
future to split the cozy-dataproxy-lib into 2 dedicated libraries for
the consuming apps and for the dataproxy part (which is the one
requiring cozy-pouch-link)
@paultranvan
fix: Avoid rendering at focus
85c5b4c 
At each new focus, a full render was triggered, making a visual refresh
for the user.
To fix this, we do not use query options in the ReloadFocus component,
because of: linagora/cozy-client#931
Especially for the apps query, the fetchPolicy is always applied here,
because it is called elsewhere, making the query's lastUpdate very close
in time. And because of this, the home is rendered after each focus, as
the same query gives different result (a complete response, vs an early
empty return in this case)
@Ldoppea Ldoppea merged commit 9c7d4e9 into master Feb 12, 2025
@Ldoppea Ldoppea deleted the feat/offline branch February 12, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paultranvan paultranvan paultranvan approved these changes

@acezard acezard Awaiting requested review from acezard

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ldoppea @paultranvan