feat: Handle queries that fetch Konnectors by channel#1534
Merged
Ldoppea merged 1 commit intofeat/meta_offlinefrom Sep 24, 2024
Merged
feat: Handle queries that fetch Konnectors by channel#1534Ldoppea merged 1 commit intofeat/meta_offlinefrom
Ldoppea merged 1 commit intofeat/meta_offlinefrom
Conversation
Ldoppea
requested review from
Merkur39,
cballevre and
paultranvan
as code owners
Ldoppea
force-pushed
the
feat/improve_cozylink_typing
branch
from
2921150 to
039cf13
Compare
Ldoppea
force-pushed
the
feat/handle_fetch_konnectors
branch
from
54d8680 to
05641b0
Compare
Ldoppea
force-pushed
the
feat/improve_cozylink_typing
branch
from
039cf13 to
cba2711
Compare
Ldoppea
force-pushed
the
feat/handle_fetch_konnectors
branch
from
05641b0 to
cf2a800
Compare
paultranvan
approved these changes
Sep 23, 2024
| const fetchKonnectorsByChannel = async (channel, doctype, stackClient) => { | ||
| const resp = await stackClient.fetchJSON( | ||
| 'GET', | ||
| `/registry?versionsChannel=${channel}&filter[type]=konnector&limit=300` |
Contributor
There was a problem hiding this comment.
Since we cannot increase the limit from the app anymore (we might need eventually to extend the getById to allow options), I would increase it from 300 to 500
Contributor
Author
There was a problem hiding this comment.
I would suggest to skip the "options" thing and to implement it if we need to change the value someday.
Base automatically changed from
feat/improve_cozylink_typing
to
feat/meta_offline
September 23, 2024 16:46
Ldoppea
force-pushed
the
feat/handle_fetch_konnectors
branch
from
cf2a800 to
2fcf290
Compare
`fetchJSON()` calls are not compatible with offline mode unless we wrap them in the `.query()` dsl Recently we added a `fetchJSON()` call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors section So we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode Related PR: linagora/cozy-home#2186
Ldoppea
force-pushed
the
feat/handle_fetch_konnectors
branch
from
2fcf290 to
ecb276d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchJSON()calls are not compatible with offline mode unless we wrap them in the.query()dslRecently we added a
fetchJSON()call inside of cozy-home in order to display the new grouped-by-category folders in the home's konnectors sectionSo we want to move this call inside of the AppsRegistryCollection in order to make it compatible with offline mode
Related PR: linagora/cozy-home#2186