Make "@lightningtv/solid" usable as "jsxImportSource" #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetarnav
force-pushed
the
jsx-import-source-2
branch
from
921fe6d to
318acdc
Compare
Contributor
|
Can we merge this into RC3 and do it as next major release? |
thetarnav
force-pushed
the
jsx-import-source-2
branch
from
318acdc to
f7c6269
Compare
thetarnav
force-pushed
the
jsx-import-source-2
branch
from
f7c6269 to
f964713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "lighter" version of #34
Or a step towards.
It's not breaking.
It just adds a
@lightningtv/solid/jsx-runtimeexport,that can be passed to
tsconfig.json#compilerOptionsas"jsxImportSource": "@lightningtv/solid".Which just reexports the
JSXnamespace fromsolid-js,but the applied module modifications are working,
and
<view>and<text>can be used with correct types.