Skip to content

Conversation

@thetarnav
Copy link
Member

@thetarnav thetarnav commented Apr 1, 2025

This makes the JSX namespace separate from one in solid-js.
Unfortunately even though we implement a custom renderer and don't use solid-js/web, we cannot use the JSX namespace from solid-js as it is reexported from solid-js/web. (Related issue: solidjs/solid#2051)
Because of this, every function that uses JSX from solid-js (like Show, For, or Route from the solidjs router) need to be implemented as the two JSX namespaces are not compatible.
So now @lightningtv/solid reexports everything from solid-js while "fixing" the types, so now everything can (has to) be imported from @lightningtv/solid.
With this "jsxImportSource" has to also be set to "@lightningtv/solid" to use the new JSX types.
This is quite a breaking change type-wise.

@chiefcll
Copy link
Contributor

chiefcll commented Apr 3, 2025

Can we close this out in favor of #35 going in

@thetarnav
Copy link
Member Author

I still think there is value here so I don’t think of it as closed.
#35 was a non-breaking step towards independent JSX types.
There will probably need to be few more steps like that (like reexporting solidjs apis, List, Router etc.) before this PR doesn’t seem like that big of a deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants