Skip to content

fix: preserve falsy values (0, false) in getTokens, getChains, getTools #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chybisov merged 2 commits into from
Mar 20, 2026
+6 −3
Merged

fix: preserve falsy values (0, false) in getTokens, getChains, getTools #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
322c84f
fix: preserve falsy values (0, false) in getTokens, getChains, getToo…
claude Mar 20, 2026
0da9aa5
Merge branch 'main' into claude/slack-add-pepe-token-list-ZIzty
chybisov Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/sdk/src/actions/getChains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ export const _getChains = async (
): Promise<ExtendedChain[]> => {
if (params) {
for (const key of Object.keys(params)) {
if (!params[key as keyof ChainsRequest]) {
const value = params[key as keyof ChainsRequest]
if (value === undefined || value === null) {
delete params[key as keyof ChainsRequest]
}
}
Expand Down
3 changes: 2 additions & 1 deletion packages/sdk/src/actions/getTokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ export async function getTokens(
): Promise<TokensResponse> {
if (params) {
for (const key of Object.keys(params)) {
if (!params[key as keyof TokensRequest]) {
const value = params[key as keyof TokensRequest]
if (value === undefined || value === null) {
delete params[key as keyof TokensRequest]
}
}
Expand Down
3 changes: 2 additions & 1 deletion packages/sdk/src/actions/getTools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ export const getTools = async (
): Promise<ToolsResponse> => {
if (params) {
for (const key of Object.keys(params)) {
if (!params[key as keyof ToolsRequest]) {
const value = params[key as keyof ToolsRequest]
if (value === undefined || value === null) {
delete params[key as keyof ToolsRequest]
}
}
Expand Down
Loading