fix: preserve falsy values (0, false) in getTokens, getChains, getTools#368
Merged
fix: preserve falsy values (0, false) in getTokens, getChains, getTools#368
Conversation
…ls params The cleanup loop was deleting params where !params[key] was truthy. Since 0 and false are falsy in JS, passing minPriceUSD: 0 or extended: false resulted in those params being stripped before the API call. This caused the API to apply server-side defaults (e.g., minPriceUSD: 0.0001), returning fewer tokens than expected. For example, PEPE on Arbitrum was missing from getTokens() results despite being tradeable on Jumper Exchange. Fix: Replace !params[key] with params[key] === undefined || params[key] === null https://claude.ai/code/session_018MDKDF3K5YHTdcVDnD5iqS
chybisov
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
https://linear.app/lifi-linear/issue/EMB-315/sdk-strips-minpriceusd-0-from-gettokens-requests
Why was it implemented this way?
The cleanup loop was deleting params where !params[key] was truthy. Since 0 and false are falsy in JS, passing minPriceUSD: 0 or extended: false resulted in those params being stripped before the API call.
This caused the API to apply server-side defaults (e.g., minPriceUSD: 0.0001), returning fewer tokens than expected. For example, PEPE on Arbitrum was missing from getTokens() results despite being tradeable on Jumper Exchange.
Fix: Replace !params[key] with params[key] === undefined || params[key] === null
Checklist before requesting a review