Skip to content

Fix Node 22 and add account environment variable #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jagoda merged 2 commits into from
Aug 26, 2025
Merged

Fix Node 22 and add account environment variable #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32bec4f
fix: Remove Cognito patch
jagoda Aug 26, 2025
15af43e
feat: Allow setting account with PHC_ACCOUNT
jagoda Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const MAX_PARTS = 10000;
function request (options, condition = isNetworkOrIdempotentRequestError) {
const environment = config.getEnvironment();

const account = options.account || config.get(`${environment}.defaults.account`);
const account = options.account || process.env.PHC_ACCOUNT || config.get(`${environment}.defaults.account`);
if (!account) {
throw new Error(`Account needs to be set with 'lo defaults' or specified with the -a option.`);
}
Expand Down
3 changes: 0 additions & 3 deletions lo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ const chalk = require('chalk');
const debug = require('debug')('lo');
const yargs = require('yargs');

// Needed because the cognito library tries to fetch the user-agent from the browser
global.navigator = () => null;
Copy link
Copy Markdown
Contributor Author

@jagoda jagoda Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, the Cognito library referenced here was removed here. I suspect this was just never updated.

Copy link
Copy Markdown
Contributor Author

@jagoda jagoda Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, this line breaks in Node 22 because global.navigator is immutable.


function handleError (msg, err) {
debug(`%j`, msg);
if (err && err.response) {
Expand Down
Loading