Skip to content

Fix Node 22 and add account environment variable#243

Merged
jagoda merged 2 commits intomasterfrom
fix-node
Aug 26, 2025
Merged

Fix Node 22 and add account environment variable#243
jagoda merged 2 commits intomasterfrom
fix-node

Conversation

@jagoda
Copy link
Copy Markdown
Contributor

@jagoda jagoda commented Aug 26, 2025

No description provided.

jagoda added 2 commits August 26, 2025 13:07
The Cognito identity library is no longer used.
This makes it possible to use the CLI in non-interactive
environments where `lo setup` may not have been run.
@jagoda jagoda changed the title Fix Node and add account environment variable Fix Node 22 and add account environment variable Aug 26, 2025
const yargs = require('yargs');

// Needed because the cognito library tries to fetch the user-agent from the browser
global.navigator = () => null;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, the Cognito library referenced here was removed here. I suspect this was just never updated.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, this line breaks in Node 22 because global.navigator is immutable.

@jagoda jagoda merged commit afa8541 into master Aug 26, 2025
4 checks passed
@jagoda jagoda deleted the fix-node branch August 26, 2025 17:25
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 13.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants