Skip to content

Fix UTF-8 BOM handling in MonacoPreviewHandler to prevent crashes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix UTF-8 BOM handling in MonacoPreviewHandler to prevent crashes #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e2839a
Initial plan for issue
Copilot May 25, 2025
013207a
Fix UTF-8 BOM handling in MonacoPreviewHandler
Copilot May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,15 @@ private void InitializeIndexFileAndSelectedFile(string filePath)
}

fileReader.Close();

// Remove BOM character if present to avoid encoding issues when converting to base64
// BOM character might be present as U+FEFF even though StreamReader should normally handle it
if (fileContent.Length > 0 && fileContent[0] == '\uFEFF')
{
fileContent = fileContent.Substring(1);
Logger.LogInfo("Removed UTF-8 BOM character from file content");
}

_base64FileCode = Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(fileContent));
Logger.LogInfo("Reading requested file ended");
}
Expand Down