Fix UTF-8 BOM handling in MonacoPreviewHandler to prevent crashes#17
Draft
Fix UTF-8 BOM handling in MonacoPreviewHandler to prevent crashes#17
Conversation
Co-authored-by: lei9444 <39758135+lei9444@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] PowerToys.MonacoPreviewHandler crashes when rendering UTF-8 BOM
Fix UTF-8 BOM handling in MonacoPreviewHandler to prevent crashes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
PowerToys.MonacoPreviewHandler crashes when trying to render files with UTF-8 BOM (Byte Order Mark). This issue affects users who want to preview text files with UTF-8 BOM encoding in File Explorer's preview pane.
Root cause
When reading a file with UTF-8 BOM using StreamReader:
\uFEFF) can remain in the string content afterReadToEnd()Solution
The fix adds an explicit check to detect and remove the BOM character after reading the file content:
This ensures that any UTF-8 BOM is properly handled before base64 conversion, preventing the crash while maintaining correct rendering of the file content.
Fixes #16.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)crl3.digicert.comdotnet build src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandler.csproj(dns block)ocsp.digicert.comdotnet build src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandler.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.