Skip to content

Conversation

@kim-em
Copy link
Contributor

@kim-em kim-em commented Jan 7, 2026

This PR improves the CI error message when a contributor's branch is based on an older version of master that doesn't have the updated runLinter with --trace support.

Previously, the lint step would fail with a cryptic "cannot parse arguments" error. Now it detects that specific error and shows a clear message explaining the contributor needs to merge master:

==============================================================================
ERROR: Your branch uses an older version of runLinter that doesn't support
the --trace flag. Please merge 'master' into your PR branch to get the
updated linter, then push again.

You can do this with:
  git fetch upstream
  git merge upstream/master
  git push
==============================================================================

🤖 Prepared with Claude Code

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

PR summary 78c8a8dc7d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

When a PR is based on an older version of master that doesn't have the
updated runLinter with --trace support, the CI lint step fails with
a cryptic "cannot parse arguments" error.

This change detects that specific error and shows a clear message
explaining that the contributor needs to merge master into their PR.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@kim-em kim-em force-pushed the kim/ci-lint-merge-message branch from ce0e77f to e5d4595 Compare January 7, 2026 01:44
@bryangingechen
Copy link
Contributor

Thanks!
bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 7, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 7, 2026
This PR improves the CI error message when a contributor's branch is based on an older version of master that doesn't have the updated `runLinter` with `--trace` support.

Previously, the lint step would fail with a cryptic "cannot parse arguments" error. Now it detects that specific error and shows a clear message explaining the contributor needs to merge master:

```
==============================================================================
ERROR: Your branch uses an older version of runLinter that doesn't support
the --trace flag. Please merge 'master' into your PR branch to get the
updated linter, then push again.

You can do this with:
  git fetch upstream
  git merge upstream/master
  git push
==============================================================================
```

🤖 Prepared with Claude Code
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2026

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jan 7, 2026
This PR improves the CI error message when a contributor's branch is based on an older version of master that doesn't have the updated `runLinter` with `--trace` support.

Previously, the lint step would fail with a cryptic "cannot parse arguments" error. Now it detects that specific error and shows a clear message explaining the contributor needs to merge master:

```
==============================================================================
ERROR: Your branch uses an older version of runLinter that doesn't support
the --trace flag. Please merge 'master' into your PR branch to get the
updated linter, then push again.

You can do this with:
  git fetch upstream
  git merge upstream/master
  git push
==============================================================================
```

🤖 Prepared with Claude Code
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2026

Build failed:

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2026

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed ready-to-merge This PR has been sent to bors. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). labels Jan 7, 2026
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@kim-em
Copy link
Contributor Author

kim-em commented Jan 7, 2026

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 7, 2026
@kim-em
Copy link
Contributor Author

kim-em commented Jan 7, 2026

bors r-

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2026

Canceled.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the ready-to-merge This PR has been sent to bors. label Jan 7, 2026
@kim-em kim-em force-pushed the kim/ci-lint-merge-message branch from 4f0fefe to 3bea8db Compare January 7, 2026 21:39
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@kim-em kim-em force-pushed the kim/ci-lint-merge-message branch from 3bea8db to 511d84d Compare January 7, 2026 21:39
@kim-em
Copy link
Contributor Author

kim-em commented Jan 7, 2026

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 7, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 7, 2026
This PR improves the CI error message when a contributor's branch is based on an older version of master that doesn't have the updated `runLinter` with `--trace` support.

Previously, the lint step would fail with a cryptic "cannot parse arguments" error. Now it detects that specific error and shows a clear message explaining the contributor needs to merge master:

```
==============================================================================
ERROR: Your branch uses an older version of runLinter that doesn't support
the --trace flag. Please merge 'master' into your PR branch to get the
updated linter, then push again.

You can do this with:
  git fetch upstream
  git merge upstream/master
  git push
==============================================================================
```

🤖 Prepared with Claude Code
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(ci): show helpful message when runLinter needs master merge [Merged by Bors] - fix(ci): show helpful message when runLinter needs master merge Jan 7, 2026
@mathlib-bors mathlib-bors bot closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants