-
Notifications
You must be signed in to change notification settings - Fork 990
[Merged by Bors] - fix(ci): show helpful message when runLinter needs master merge #33696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix(ci): show helpful message when runLinter needs master merge #33696
Conversation
PR summary 78c8a8dc7dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
When a PR is based on an older version of master that doesn't have the updated runLinter with --trace support, the CI lint step fails with a cryptic "cannot parse arguments" error. This change detects that specific error and shows a clear message explaining that the contributor needs to merge master into their PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ce0e77f to
e5d4595
Compare
|
Thanks! |
This PR improves the CI error message when a contributor's branch is based on an older version of master that doesn't have the updated `runLinter` with `--trace` support. Previously, the lint step would fail with a cryptic "cannot parse arguments" error. Now it detects that specific error and shows a clear message explaining the contributor needs to merge master: ``` ============================================================================== ERROR: Your branch uses an older version of runLinter that doesn't support the --trace flag. Please merge 'master' into your PR branch to get the updated linter, then push again. You can do this with: git fetch upstream git merge upstream/master git push ============================================================================== ``` 🤖 Prepared with Claude Code
|
Build failed (retrying...): |
This PR improves the CI error message when a contributor's branch is based on an older version of master that doesn't have the updated `runLinter` with `--trace` support. Previously, the lint step would fail with a cryptic "cannot parse arguments" error. Now it detects that specific error and shows a clear message explaining the contributor needs to merge master: ``` ============================================================================== ERROR: Your branch uses an older version of runLinter that doesn't support the --trace flag. Please merge 'master' into your PR branch to get the updated linter, then push again. You can do this with: git fetch upstream git merge upstream/master git push ============================================================================== ``` 🤖 Prepared with Claude Code
|
Build failed: |
|
✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
|
bors merge |
|
bors r- |
|
Canceled. |
4f0fefe to
3bea8db
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3bea8db to
511d84d
Compare
|
bors merge |
This PR improves the CI error message when a contributor's branch is based on an older version of master that doesn't have the updated `runLinter` with `--trace` support. Previously, the lint step would fail with a cryptic "cannot parse arguments" error. Now it detects that specific error and shows a clear message explaining the contributor needs to merge master: ``` ============================================================================== ERROR: Your branch uses an older version of runLinter that doesn't support the --trace flag. Please merge 'master' into your PR branch to get the updated linter, then push again. You can do this with: git fetch upstream git merge upstream/master git push ============================================================================== ``` 🤖 Prepared with Claude Code
|
Pull request successfully merged into master. Build succeeded: |
This PR improves the CI error message when a contributor's branch is based on an older version of master that doesn't have the updated
runLinterwith--tracesupport.Previously, the lint step would fail with a cryptic "cannot parse arguments" error. Now it detects that specific error and shows a clear message explaining the contributor needs to merge master:
🤖 Prepared with Claude Code