Skip to content

Conversation

@bryangingechen
Copy link
Contributor

#33696 changed the linting step so that it pipes its output into tee; this causes lake exe runLinter to block buffer its output, which means that if the linters freeze (cf. #mathlib4 > slow linting step CI?), we may not see all of the log output.

This PR uses stdbuf -oL to make the output line buffered instead, which should solve this.


Open in Gitpod

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Jan 9, 2026
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

PR summary ee6d0f13b3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adomani
Copy link
Collaborator

adomani commented Jan 9, 2026

Let's try this!

Since the change is on the main CI build, I'll delegate: please, merge when you can monitor that everything is fine after it reaches master!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 9, 2026

✌️ bryangingechen can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 9, 2026
@bryangingechen
Copy link
Contributor Author

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 9, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2026
…33783)

#33696 changed the linting step so that it pipes its output into `tee`; this causes `lake exe runLinter` to block buffer its output, which means that if the linters freeze (cf. [#mathlib4 > slow linting step CI?](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/slow.20linting.20step.20CI.3F/with/567049377)), we may not see all of the log output.

This PR uses [`stdbuf -oL`](https://www.gnu.org/software/coreutils/manual/html_node/stdbuf-invocation.html) to make the output line buffered instead, which should solve this.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 9, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title ci: wrap linting with stdbuf -oL so log output appears immediately [Merged by Bors] - ci: wrap linting with stdbuf -oL so log output appears immediately Jan 9, 2026
@mathlib-bors mathlib-bors bot closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants