Skip to content

add an input option to short-circuit post-init-comms #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yurlungur merged 2 commits into from
Jun 27, 2022
Merged

add an input option to short-circuit post-init-comms #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
446d4fb
add an input option to short-circuit post-init-comms
jonahm-LANL Jun 27, 2022
e72d62f
formatting
jonahm-LANL Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/phoebus_driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ TaskListStatus PhoebusDriver::Step() {
// TODO(BRR) This is required for periodic BCs, unless the issue is radiation not being
// included in ConvertBoundaryConditions
void PhoebusDriver::PostInitializationCommunication() {
auto phoebus_package = pmesh->packages.Get("phoebus");
auto do_post_init_comms = phoebus_package->Param<bool>("do_post_init_comms");
if (!do_post_init_comms) return;

TaskCollection tc;
TaskID none(0);
BlockList_t &blocks = pmesh->block_list;
Expand Down
2 changes: 2 additions & 0 deletions src/phoebus_package.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ std::shared_ptr<StateDescriptor> Initialize(ParameterInput *pin) {
params.Add("tlim", pin->GetReal("parthenon/time", "tlim"));
params.Add("nlim", pin->GetReal("parthenon/time", "nlim"));
params.Add("integrator", pin->GetString("parthenon/time", "integrator"));
params.Add("do_post_init_comms",
pin->GetOrAddBoolean("phoebus", "do_post_init_comms", false));
Comment on lines +36 to +37
Copy link
Collaborator

@lroberts36 lroberts36 Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this default to off or on? I would say default to on.

Copy link
Collaborator

@brryan brryan Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think default off is OK since it is currently broken -- can switch to on when it gets fixed


// Store unit conversions
params.Add("unit_conv", phoebus::UnitConversions(pin));
Expand Down