add an input option to short-circuit post-init-comms #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
requested review from
brryan,
jdolence,
jti-lanl,
kssheridan and
lroberts36
lroberts36
approved these changes
Jun 27, 2022
Collaborator
lroberts36
left a comment
lroberts36
left a comment
There was a problem hiding this comment.
This looks ok to me as a temporary fix since (I think) the PostInitializationCommunication is only necessary for periodic boundary conditions.
Comment on lines
+36
to
+37
| params.Add("do_post_init_comms", | ||
| pin->GetOrAddBoolean("phoebus", "do_post_init_comms", false)); |
Collaborator
There was a problem hiding this comment.
Should this default to off or on? I would say default to on.
Collaborator
There was a problem hiding this comment.
I think default off is OK since it is currently broken -- can switch to on when it gets fixed
brryan
approved these changes
Jun 27, 2022
Comment on lines
+36
to
+37
| params.Add("do_post_init_comms", | ||
| pin->GetOrAddBoolean("phoebus", "do_post_init_comms", false)); |
Collaborator
There was a problem hiding this comment.
I think default off is OK since it is currently broken -- can switch to on when it gets fixed
kssheridan
approved these changes
Jun 27, 2022
Collaborator
|
This runs successfully on 4 devkit nodes. |
Collaborator
|
Dang it. Sorry. Didn't mean to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Given the segfaults happening due to
PostInitializationCommunication, I'm adding a runtime option to disable it. Adds an input parameter in thephoebusblock.In the long term, we need to pull #118 through. Alternatively, changes upstream in Parthenon may make this driver stage unnecessary. @brryan what are your thoughts?
PR Checklist
scripts/bash/format.sh.