Skip to content

ci: add go mod tidy check #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesuperzapper wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from
+13 −3
Open

ci: add go mod tidy check #814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ws-backend-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ jobs:
check-latest: true
cache-dependency-path: workspaces/backend/go.sum

- ## NOTE: this will cause the porcelain check to fail if go.mod/go.sum are out of date
name: Go Mod Tidy
working-directory: workspaces/backend
run: go mod tidy

- name: Lint
working-directory: workspaces/backend
run: make lint
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ws-controller-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ jobs:
check-latest: true
cache-dependency-path: workspaces/controller/go.sum

- ## NOTE: this will cause the porcelain check to fail if go.mod/go.sum are out of date
name: Go Mod Tidy
working-directory: workspaces/controller
run: go mod tidy

- name: Lint
working-directory: workspaces/controller
run: make lint
Expand Down
2 changes: 1 addition & 1 deletion workspaces/backend/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubeflow/notebooks/workspaces/backend

go 1.22.0
go 1.22.12

replace github.com/kubeflow/notebooks/workspaces/controller => ../controller

Expand Down
4 changes: 2 additions & 2 deletions workspaces/controller/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
module github.com/kubeflow/notebooks/workspaces/controller

go 1.22.0
go 1.22.12

require (
github.com/go-logr/logr v1.4.2
github.com/onsi/ginkgo/v2 v2.19.0
github.com/onsi/gomega v1.33.1
golang.org/x/time v0.3.0
google.golang.org/protobuf v1.34.2
istio.io/api v1.22.8
istio.io/client-go v1.22.8
k8s.io/api v0.31.0
Expand Down Expand Up @@ -62,7 +63,6 @@ require (
golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20240528184218-531527333157 // indirect
google.golang.org/protobuf v1.34.2 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
Expand Down