Skip to content

Conversation

@thesuperzapper
Copy link
Member

To avoid people forgetting to update the go.mod and go.sum files, this PR ensures we run go mod tidy in our PR tests, which should cause the porcelain check to fail as there would be uncommitted changes.

This PR also fixes the fact that someone forgot to run go mod tidy on the controller, and also updates to the latest version of Go 1.22 in our go mod files.

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Dec 19, 2025
@google-oss-prow google-oss-prow bot added the area/backend area - related to backend components label Dec 19, 2025
@google-oss-prow google-oss-prow bot requested a review from kimwnasptd December 19, 2025 20:27
@google-oss-prow google-oss-prow bot added area/ci area - related to ci area/controller area - related to controller components area/v2 area - version - kubeflow notebooks v2 size/S labels Dec 19, 2025
@ederign
Copy link
Member

ederign commented Dec 22, 2025

/approve
/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ederign
Once this PR has been reviewed and has the lgtm label, please ask for approval from thesuperzapper. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/backend area - related to backend components area/ci area - related to ci area/controller area - related to controller components area/v2 area - version - kubeflow notebooks v2 lgtm size/S

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants