Skip to content

Conversation

@lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Dec 1, 2025

Description

Implement extension mechanism in bff so we can override code in other codebases.

How Has This Been Tested?

Add a new extension folder with docs to know how to enable it.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lucferbux. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux lucferbux force-pushed the extension-mechanism-bff branch from 1a10968 to 93305e4 Compare December 30, 2025 11:23
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Dec 30, 2025
@lucferbux lucferbux force-pushed the extension-mechanism-bff branch 2 times, most recently from 9378a87 to 4792247 Compare December 30, 2025 11:30
- Added a new function `NewKubernetesClientFactory` to handle client creation based on authentication method.
- Introduced a new markdown file for documenting BFF handler extensions for downstream builds.
- Implemented handler overrides for Model Registry Settings to support Red Hat-specific behavior.
- Created a new repository for Model Registry Settings with Kubernetes integration.
- Added methods for CRUD operations on Model Registry settings, including handling database secrets.
- Implemented conversion functions for unstructured Kubernetes objects to strongly typed models.
- Ensured that all new functionality adheres to existing interfaces and maintains backward compatibility.

feat: adapt the code to upstream

Signed-off-by: lucferbux <lferrnan@redhat.com>
@lucferbux lucferbux force-pushed the extension-mechanism-bff branch from 4792247 to 9c576a2 Compare December 30, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants