[DO NOT MERGE] Refactor Kubernetes Client Factory and Introduce Red Hat Extensions #1934
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
lucferbux
force-pushed
the
bff-override
branch
3 times, most recently
from
d8b3d0e to
b2fb2a5
Compare
| func shouldUseRedHatOverrides(app *api.App) bool { | ||
| return app != nil | ||
| } |
There was a problem hiding this comment.
@lucferbux when I tried to run the application in mock mode - getting 500 error, as this condition is always true and uses the override. Was that expected?
There was a problem hiding this comment.
oh that's a great catch, don't worry too much here cause I need to raise another PR with that specific folder downstream but I forgot to include in this wip the other condition, updating, once it's there, can you focus on reviewing #1935 ?
There was a problem hiding this comment.
Thanks a lot for everything!
There was a problem hiding this comment.
can you focus on reviewing #1935 ?
yeah sure, Thanks @lucferbux !!
- Added a new function `NewKubernetesClientFactory` to handle client creation based on authentication method. - Introduced a new markdown file for documenting BFF handler extensions for downstream builds. - Implemented handler overrides for Model Registry Settings to support Red Hat-specific behavior. - Created a new repository for Model Registry Settings with Kubernetes integration. - Added methods for CRUD operations on Model Registry settings, including handling database secrets. - Implemented conversion functions for unstructured Kubernetes objects to strongly typed models. - Ensured that all new functionality adheres to existing interfaces and maintains backward compatibility.
lucferbux
force-pushed
the
bff-override
branch
from
b2fb2a5 to
48a1d40
Compare
|
Closing this in favor of #1935 |
3 participants
@mturley @ppadti @manaswinidas This is the referece with all the code, I will follow up with a PR that is exclusively the override to merge, and then another fake PR downstream to test the implementation