-
-
Notifications
You must be signed in to change notification settings - Fork 5
Fix gem requires #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix gem requires #118
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require_relative "bas/version" | ||
| require_relative "bas/bot/base" | ||
| require_relative "bas/shared_storage/base" | ||
| require_relative "bas/shared_storage/default" | ||
| require_relative "bas/shared_storage/postgres" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don’t think this should be added by default when the gem is imported. Users should have the flexibility to import only the shared storage implementation required for their specific use case. Currently, postgres is the only option available, but in the future, we plan to add more implementations. For example, if a user wants to use shared storage with S3, importing the postgres module should not be enforced. Let me know what you think! 🤔 |
||
|
|
||
| module Bas | ||
| class Error < StandardError; end | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use double quotes