Open
Conversation
zarmeza
commented
Nov 18, 2024
zarmeza
commented
- Add require_relative to expose bot and shared storage classes
- Update README
Pull Request Test Coverage Report for Build 11902121813Details
💛 - Coveralls |
zarmeza
commented
Nov 19, 2024
| For this, a bot could be defined as follow: | ||
|
|
||
| ```ruby | ||
| require 'bas' |
FelipeGuzmanSierra
requested changes
Nov 19, 2024
Collaborator
FelipeGuzmanSierra
left a comment
FelipeGuzmanSierra
left a comment
There was a problem hiding this comment.
Great, just a few comments!
| require_relative "bas/bot/base" | ||
| require_relative "bas/shared_storage/base" | ||
| require_relative "bas/shared_storage/default" | ||
| require_relative "bas/shared_storage/postgres" |
Collaborator
There was a problem hiding this comment.
I don’t think this should be added by default when the gem is imported. Users should have the flexibility to import only the shared storage implementation required for their specific use case. Currently, postgres is the only option available, but in the future, we plan to add more implementations. For example, if a user wants to use shared storage with S3, importing the postgres module should not be enforced.
Let me know what you think! 🤔
L-Zuluaga
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.