Skip to content

Fix Windows test cleanup by correctly targeting .exe executables #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
walker84837 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Windows test cleanup by correctly targeting .exe executables #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions kitc/tests/examples.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,18 @@ fn run_example_test(
);

let source_path = workspace_root.join(example_file);
let c_path = source_path.with_extension("c");
let executable_path = source_path.with_extension("");
let ext = if cfg!(windows) { "exe" } else { "" };
let executable_path = source_path.with_extension(ext);

// Compile the example
let kitc = cargo_bin!("kitc");
log::info!("kitc path: {}", kitc.display());

// Note: C file cleanup is handled by the compiler itself (see frontend.rs).
// SAFETY: these unit tests are single-threaded, so no race conditions
// unsafe {
// std::env::set_var("KEEP_C", "");
// }
let mut cmd = AssertCommand::from_std(Command::new(kitc));

// Run from workspace root
Expand All @@ -75,14 +81,10 @@ fn run_example_test(
.stdout(predicate::eq(expected_output.as_str()))
.success();

// TODO: executable files are actually generated in the CWD, not in the examples folder.
// This explains why the executable is not actually generated in the examples folder.
// Cleanup generated files
if let Err(err) = std::fs::remove_file(&executable_path) {
log::error!("Failed to remove executable: {err}");
}
if let Err(err) = std::fs::remove_file(&c_path) {
log::error!("Failed to remove C source file: {err}");
}

Ok(())
}
Expand Down