Fix Windows test cleanup by correctly targeting .exe executables
#10
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted file extensions and cleanup for cross-platform compatibility in example tests. Summary of changes: - Reordered `assert_cmd` imports for clarity - Set executable extension based on OS (`exe` for Windows) - Removed redundant C file handling - Ensure generated executables are cleaned up after tests - Added safety notes about single-threaded tests and setting KEEP_C env var for testing incorrect C code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where example tests on Windows leave behind residual
.exefiles after running. The root problem was that the test cleanup logic assumed Unix-style executables (no extension), so the final Windows binaries were never removed.What changed
run_example_testis now constructed conditionally:.exeon WindowsWhy this works
On Windows,
Commandexecution produces<example>.exe, but the test cleanup attempted to delete<example>instead. By aligning the executable path with platform conventions, the tests now clean up after themselves consistently, matching Linux/macOS behavior.Related Issue
Fixes #8