feat: extract search functionality into standalone module#36
Merged
kdroidFilter merged 5 commits intomasterfrom Jan 18, 2026
Merged
feat: extract search functionality into standalone module#36kdroidFilter merged 5 commits intomasterfrom
kdroidFilter merged 5 commits intomasterfrom
Conversation
- Add new search module with JVM-only target - Create SearchEngine, SearchSession, SnippetProvider interfaces - Migrate LuceneSearchEngine from SeforimApp - Migrate MagicDictionaryIndex and HebrewTextUtils - Add comprehensive test suite (66 tests)
3 tasks
- Add comprehensive KDoc to SearchEngine, SearchSession, SnippetProvider - Include usage examples and thread safety notes - Document all parameters and return values - Move jsoup dependency to version catalog (1.18.3)
- Run all module tests on PR - Run search module tests explicitly - Upload test reports as artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
./gradlew :search:jvmTest- all 66 tests pass