refactor: use extracted search module from SeforimLibrary#279
Merged
kdroidFilter merged 8 commits intomasterfrom Jan 18, 2026
Merged
refactor: use extracted search module from SeforimLibrary#279kdroidFilter merged 8 commits intomasterfrom
kdroidFilter merged 8 commits intomasterfrom
Conversation
- Add dependency on SeforimLibrary:search module - Update DI to provide SearchEngine interface - Adapt SearchResultViewModel and SearchHomeViewModel - Update RepositorySnippetSourceProvider to implement SnippetProvider - Remove deprecated LuceneSearchService and MagicDictionary - Fix pagination module (remove unused distinctByTargetLine param)
- Include KDoc documentation for search interfaces - Use version catalog for jsoup dependency
- Run SeforimLibrary tests before builds - Run SeforimApp JVM tests - Upload test reports as artifacts - Update SeforimLibrary submodule with CI workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
Test plan