refactor: split commands into individual functions #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
commented
Oct 21, 2025
Comment on lines
+279
to
+281
| project_root: Utf8PathBuf, | ||
| project_file: Utf8PathBuf, | ||
| start_relpath: Utf8PathBuf, |
Contributor
Author
There was a problem hiding this comment.
This should probably be merged into a ProjectInfo struct in the future.
Contributor
|
Bencher Report| Branch | pr/refactor/split_commands |
| Testbed | github-actions |
Click to view all benchmark results
| Benchmark | perf:task-clock | Benchmark Result msec x 1e3 (Result Δ%) | Upper Boundary msec x 1e3 (Limit %) |
|---|---|---|---|
| laze -C RIOT build --global --generate-only | 📈 view plot 🚷 view threshold | 9.06 x 1e3(-3.39%)Baseline: 9.38 x 1e3 | 10.21 x 1e3 (88.70%) |
bergzand
force-pushed
the
pr/refactor/split_commands
branch
from
382730a to
05de713
Compare
kaspar030
force-pushed
the
pr/refactor/split_commands
branch
from
05de713 to
7db2a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the complexity and cognitive burden of
try_main()by splitting the subcommands into individual functions, significantly reducing the length of thetry_main()function.This is purely a refactor and output should not be affected.