feat: add inspect for builders command #807
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
commented
Oct 22, 2025
Comment on lines
+24
to
+34
| fn add_tree_element(&self, context: &Context, tree: &mut TreeBuilder) { | ||
| self.contexts | ||
| .contexts | ||
| .iter() | ||
| .filter(|c| Some(context) == c.get_parent(&self.contexts)) | ||
| .for_each(|c| { | ||
| tree.begin_child(c.name.to_string()); | ||
| self.add_tree_element(c, tree); | ||
| tree.end_child(); | ||
| }) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is a bit of a blunt recursive iteration over all contexts. I don't know whether it is sufficiently performant.
src/inspect.rs
Outdated
| self.contexts | ||
| .contexts | ||
| .iter() | ||
| .filter(|c| c.get_parent(&self.contexts).is_none()) |
Contributor
Author
There was a problem hiding this comment.
There must be a better way to get that single default context 😆
Owner
There was a problem hiding this comment.
There is contextbag.get_by_name("default")
Contributor
|
Bencher Report| Branch | pr/feat/inspect |
| Testbed | github-actions |
Click to view all benchmark results
| Benchmark | perf:task-clock | Benchmark Result msec x 1e3 (Result Δ%) | Upper Boundary msec x 1e3 (Limit %) |
|---|---|---|---|
| laze -C RIOT build --global --generate-only | 📈 view plot 🚷 view threshold | 9.42 x 1e3(+0.39%)Baseline: 9.38 x 1e3 | 9.96 x 1e3 (94.62%) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first steps for a
laze inspectsubcommand. This PR adds alaze inspect builderscommand to list a flat list of builders available, or with the--treeoption, a full hierarchy of contexts.Issues/PRs references
Depends on #806