Fix notebook undefined best in analysis notebook#166
Open
SamuelS0 wants to merge 1 commit intokarpathy:masterfrom
Open
Fix notebook undefined best in analysis notebook#166SamuelS0 wants to merge 1 commit intokarpathy:masterfrom
SamuelS0 wants to merge 1 commit intokarpathy:masterfrom
Conversation
IgorTavcar
added a commit
to IgorTavcar/autoresearch
that referenced
this pull request
Mar 11, 2026
Cherry-picked from karpathy#166 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 137 references 'best' on lines 51-52, but 'best' was never defined, causing a NameError when running cells top-to-bottom. Fixed by assigning 'best = running_min.iloc[-1]' which is already computed earlier in the same cell.