fix(notebook): define 'best' before use in plotting cell#175
Open
tykoo-chen wants to merge 1 commit intokarpathy:masterfrom
Open
fix(notebook): define 'best' before use in plotting cell#175tykoo-chen wants to merge 1 commit intokarpathy:masterfrom
tykoo-chen wants to merge 1 commit intokarpathy:masterfrom
Conversation
The plotting cell references 'best' for Y-axis limits but it was not defined until the Summary Statistics cell below. This adds the definition using running_min.iloc[-1] with a fallback to baseline_bpb if no experiments have been kept yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The plotting cell in
analysis.ipynbreferences the variablebeston lines 137-138:However,
bestis not defined until the "Summary Statistics" cell which comes later in the notebook. This causes aNameErrorwhen running the notebook.Solution
Add
best = running_min.iloc[-1]before the Y-axis limits are set, with a fallback tobaseline_bpbfor the edge case where no experiments have been kept yet.Related