This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Get project arguments from browser config#71
Open
niksy wants to merge 1 commit intokarma-runner:masterfrom
Open
Get project arguments from browser config#71niksy wants to merge 1 commit intokarma-runner:masterfrom
niksy wants to merge 1 commit intokarma-runner:masterfrom
Conversation
dignifiedquire
pushed a commit
that referenced
this pull request
Jan 14, 2017
…er basis Browserstack uses the `name` property in the browser configuration to uniquely name sessions within a specific build. If these sessions do not have a unique name, and are executed sequentially (or with a concurrency < total # of browsers), browserstack's UI will overwrite previous results with new ones. In cases where a karma test run is executed on multiple browsers, this isn't really desirable. While I was at it, I also incorporated changes from #71, and updated the README to also include documentation for that change. With this patch, `name`, `project`, and `build`, may all be overridden on a per browser basis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If user has provided Browserstack config for automate session in
customLaunchers, use those values first and then try everything else.