This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Permit overriding name, build, and project on a per-browser basis.#91
Merged
dignifiedquire merged 1 commit intokarma-runner:masterfrom Jan 14, 2017
krotscheck:permit_per_browser_name
Merged
Permit overriding name, build, and project on a per-browser basis.#91dignifiedquire merged 1 commit intokarma-runner:masterfrom krotscheck:permit_per_browser_name
name, build, and project on a per-browser basis.#91dignifiedquire merged 1 commit intokarma-runner:masterfrom
krotscheck:permit_per_browser_name
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLAs look good, thanks! |
name property per browser configuration.name, build, and project on a per-browser basis.
Browserstack uses the `name` property in the browser configuration to uniquely name sessions within a specific build. If these sessions do not have a unique name, and are executed sequentially (or with a concurrency < total # of browsers), browserstack's UI will overwrite previous results with new ones. In cases where a karma test run is executed on multiple browsers, this isn't really desirable. While I was at it, I also incorporated changes from #71, and updated the README to also include documentation for that change. With this patch, `name`, `project`, and `build`, may all be overridden on a per browser basis.
Contributor
Author
|
A note on the dependency update - it turns out that grunt-auto-release changed its grunt version requirement in 0.0.7, breaking peerDependencies in the project. For my patch to pass, I had to update the version to 0.0.6 (the last version that required grunt@~0.4). |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browserstack uses the
nameproperty in the browser configurationto uniquely name sessions within a specific build. If these sessions
do not have a unique name, and are executed sequentially (or with a
concurrency < total # of browsers), browserstack's UI will overwrite
previous results with new ones. In cases where a karma test run is
executed on multiple browsers, this isn't really desirable.
While I was at it, I also incorporated changes from #71, and
updated the README to also include documentation for that change. With
this patch,
name,project, andbuild, may all be overridden ona per browser basis.