Refactor last helper functions into utils module#230
Open
mutlusun wants to merge 10 commits intokaixxx:mainfrom
Open
Refactor last helper functions into utils module#230mutlusun wants to merge 10 commits intokaixxx:mainfrom
mutlusun wants to merge 10 commits intokaixxx:mainfrom
Conversation
mutlusun
force-pushed
the
refactor/helper-functions
branch
2 times, most recently
from
41b00b2 to
c166eb9
Compare
Dropping the dependency on AdvancedHTMLParser as the library is unmaintained.
`media_path` is not necessary anymore as it is already contained in the HTML file. Remove the reliance on AdvancedHTMLParser as it is not maintained anymore.
mutlusun
force-pushed
the
refactor/helper-functions
branch
from
c166eb9 to
9c18b94
Compare
mutlusun
force-pushed
the
refactor/helper-functions
branch
from
9c18b94 to
77ff3af
Compare
Contributor
Author
|
@kaixxx I rebased the MR to the latest changes. I think it's safe to merge it now. I also tested the MR again with the commands from the message above. |
Owner
|
That's great, thank you very much. I will take a look in the next couple of days. Have a nice weekend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last PR in this direction.
AdvancedHTMLParseras the library is unmaintained. However, the library is still used elsewhere. The code gets longer because of this but the complexity can be reduced in the future if python data types are used to convert to different file types instead of always generating a html file and parsing it.I tested the changes manually with the following commands: