refactor(ffmpeg): use pyav ffmpeg instead of own version#236
Open
mutlusun wants to merge 1 commit intokaixxx:mainfrom
Open
refactor(ffmpeg): use pyav ffmpeg instead of own version#236mutlusun wants to merge 1 commit intokaixxx:mainfrom
mutlusun wants to merge 1 commit intokaixxx:mainfrom
Conversation
This commit introduces a new audio conversion tool that uses pyav to convert audio files to the wave format. pyav bundles it's own version of ffmpeg, thus, we don't need to ship our own (outdated) version. In addition, pyav is already a dependency of faster-whisper, thus no real new dependencies are introduced.
Contributor
Author
|
Maybe it's best to merge #230 before, so tests can run properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new audio conversion module that uses pyav to convert audio files to the wave format. pyav bundles it's own version of ffmpeg, thus, we don't need to ship our own (outdated) version. In addition, pyav is already a dependency of faster-whisper, thus no real new dependencies are introduced.
This has the following advantage:
Tested the current changes with:
Unfortunately, I couldn't test whether cancelling an audio file conversion works properly. Conversion was so fast, that I never managed to press fast enough "cancel". Maybe you have a long enough audio file to test that?
Maybe it's safer to merge this after the new release. This way, the changes can be tested over a longer time.