Skip to content

Rework v2 authentication flow to better 'help' users though process#114

Merged
jtebbens merged 5 commits intojtebbens:masterfrom
DCSBL:better-auth-flow
Mar 23, 2025
Merged

Rework v2 authentication flow to better 'help' users though process#114
jtebbens merged 5 commits intojtebbens:masterfrom
DCSBL:better-auth-flow

Conversation

@DCSBL
Copy link
Copy Markdown

@DCSBL DCSBL commented Mar 22, 2025

This PR overhauls the v2 authentication flow for the P1 Meter, which can be used for the Plug-In battery once all the rough edges are dealt with.

  • No 'error in your face', just a nice prompt when you start.
  • Error handling and reporting.
  • Nice homey-style UI.

This should be fully backwards compatible with the current implementation.

Demo:

  1. v2 is selected
  2. App asks to press button, we do not do that
  3. App tells you should
  4. You do
  5. 🎉
ScreenRecording_03-22-2025.23-42-08_1.mov

@DCSBL DCSBL marked this pull request as ready for review March 22, 2025 22:51
@jtebbens jtebbens merged commit 2a579c5 into jtebbens:master Mar 23, 2025
2 checks passed
@jtebbens
Copy link
Copy Markdown
Owner

Great job, tested and confirmed it works. Pushed to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants