Skip to content

Implement eslint and lint codebase#111

Closed
DCSBL wants to merge 2 commits intojtebbens:masterfrom
DCSBL:DCSBL-2025-134
Closed

Implement eslint and lint codebase#111
DCSBL wants to merge 2 commits intojtebbens:masterfrom
DCSBL:DCSBL-2025-134

Conversation

@DCSBL
Copy link
Copy Markdown

@DCSBL DCSBL commented Mar 9, 2025

Continuing on #83

This PR:

  • Implements eslint via the default config of https://github.com/athombv/eslint-config-athom
  • Removes prettier (as this has conflicting rules, and was not used in CI)
  • Adds a pre-commit-config file; Install pre-commit, and run pre-commit install. This runs some quick checks before each commit to prevent 'invalid' commits. Can be ignored via --no-check flag per commit or even not installed at all.

All non auto-fixable rules are disabled, and can be enabled step by step.

Waits for #110

@DCSBL DCSBL closed this Mar 9, 2025
@DCSBL DCSBL deleted the DCSBL-2025-134 branch March 9, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant