Draft
Conversation
Member
|
Amazing!! Would you be able to remove the impl -> implSymbol renaming for now, or maybe do it as a separate commit? That would make review much easier (including of the generated code). |
Member
Author
|
Yes, I will do that soon. I was just too excited to share those numbers. |
a2ba621 to
5506762
Compare
ExE-Boss
reviewed
Feb 10, 2020
| value: new Impl.implementation(globalObject, constructorArgs, privateData), | ||
| configurable: true | ||
| }); | ||
| implObject[wrapperSymbol] = null; |
Contributor
There was a problem hiding this comment.
Why not use a getter that turns into a data property?
That will remove the need for createWrapperSymbol and globalObjectSymbol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR is an early draft for lazy wrapper instantiation. Instead of eagerly create a wrapper for each new impl, the wrapper is only created when accessed by userland code.
While the results are REALLY encouraging, there are still a couple of test failures in jsdom (mainly related to events). Running this change against jsdom performance benchmark we can measure a 44% reduction in memory consumption and a 20% to 200% performance improvement across all the tests. More details in the results section.
Fixes #157
Results
Memory
Benchmark Performance