refactor: Rename imported symbols#179
Merged
TimothyGu merged 3 commits intojsdom:masterfrom Mar 25, 2020
Merged
Conversation
ExE-Boss
commented
Mar 16, 2020
lib/constructs/interface.js
Outdated
| generateRequires() { | ||
| this.requires.addRaw("impl", "utils.implSymbol"); | ||
| this.requires.addRaw("ctorRegistry", "utils.ctorRegistrySymbol"); | ||
| this.requires.addRaw(`{ implSymbol, ctorRegistrySymbol }`, "utils"); |
Contributor
Author
There was a problem hiding this comment.
I’ve changed this to use object destructuring to match how alias imports are done in JSDOM.
ExE-Boss
force-pushed
the
refactor/rename-imported-symbols
branch
from
1029610 to
839fa5e
Compare
TimothyGu
approved these changes
Mar 23, 2020
This benefits from the identifier clash checking that's in addRaw.
TimothyGu
force-pushed
the
refactor/rename-imported-symbols
branch
from
e3ace27 to
96794fa
Compare
Member
|
Rebased and fixed some issues that came up in rebasing (96794fa). |
Contributor
Author
|
I had originally fixed that as part of 42e8cd5. |
Member
|
It’s possible that rebasing destroyed the merge. For future could you please rebase rather than merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve waited with opening this until after #166 was done to avoid merge conflicts.
This frees up the
implvariable for use in #158 and also makes it clearer that the currentimplvariable refers toimplSymbol.