Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds OIDC authentication support for HTTP mode deployments, fixes a previously skipped test, and updates all installation documentation to use PyPI instead of GitHub URLs.
- Adds optional OIDC authentication for HTTP transport mode with proper environment variable validation
- Fixes
test_no_data_loadedtest to properly validateNoDataLoadedErrorexception handling - Updates all documentation and client configurations to use PyPI installation (
uvx databeak)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/databeak/server.py | Adds OIDC authentication settings and integration with validation logic |
| tests/unit/servers/test_discovery_server_coverage.py | Fixes skipped test by replacing mocks with real session management |
| docs/installation.md | Updates installation commands and adds OIDC authentication documentation |
| README.md | Updates quick start examples and adds OIDC configuration section |
Comments suppressed due to low confidence (1)
src/databeak/server.py:1
- The import
DatabeakSettingsis removed but was previously used in the@smithery.server(config_schema=DatabeakSettings)decorator. Verify that removing the config schema doesn't break server configuration functionality.
"""Main FastMCP server for DataBeak."""
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| session.has_data.return_value = False | ||
| manager.return_value.get_session.return_value = session | ||
| # Create a real session without data | ||
| from databeak.exceptions import NoDataLoadedError |
There was a problem hiding this comment.
[nitpick] The import is placed inside the test function rather than at the module level. Consider moving this import to the top of the file with other imports for consistency and better readability.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 84.75% 84.68% -0.07%
==========================================
Files 27 27
Lines 3076 3089 +13
Branches 458 460 +2
==========================================
+ Hits 2607 2616 +9
- Misses 355 357 +2
- Partials 114 116 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary
This PR adds OIDC authentication support for HTTP mode deployments, fixes a skipped test in the discovery server, and updates all installation documentation to reflect PyPI as the primary installation source.
Changes
1. OIDC Authentication (HTTP Mode)
OidcSettingsclass withDATABEAK_OIDC_*environment variablesOIDCProxyfrom FastMCP for secure HTTP deploymentsEnvironment Variables:
DATABEAK_OIDC_CONFIG_URL- OIDC discovery configuration URLDATABEAK_OIDC_CLIENT_ID- OAuth2 client IDDATABEAK_OIDC_CLIENT_SECRET- OAuth2 client secretDATABEAK_OIDC_BASE_URL- Application base URL for OAuth22. Fixed Skipped Test
test_no_data_loadedintest_discovery_server_coverage.py:624NoDataLoadedErrorexception handling3. Documentation Updates
uvx --from git+...touvx databeakTest Plan
uv run pytest tests/unit/servers/test_discovery_server_coverage.pyBreaking Changes
None - this is additive functionality.
Notes
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com