Add height and width to image file data #10
Add height and width to image file data #10bendik wants to merge 1 commit intojondashkyle:masterfrom
Conversation
|
Super solid stuff. Had thought about this and held off implementing as I’d like to retain feature parity between Node’s |
|
I was imagining this working fine if If reading all the images into a buffer is unnecessary load on beaker – which seems likely – what is the best conditional to put next to I might continue to dig a little further into using the ArrayBuffer from the WebArchive API to extract the information needed to do these calculations, just for kicks. |
|
I ran into this issue before with different tradeoffs between server-side (Node) and browser-side (Beaker/web). I think it might be nice to have a standard convention for adding small bits of functionality/metadata where it makes sense on the Node side. I like the idea of checking whether |
Maybe this could be hidden in some opts for the general public that don't require variable crop ratio layout calculation on server render. ;)