Skip to content

Make the background of modules tinted.#49

Merged
kindaro merged 3 commits intojonascarpay:masterfrom
kindaro:feature-tinted-background
Apr 23, 2025
Merged

Make the background of modules tinted.#49
kindaro merged 3 commits intojonascarpay:masterfrom
kindaro:feature-tinted-background

Conversation

@kindaro
Copy link
Collaborator

@kindaro kindaro commented Apr 21, 2025

Closes #43.

@kindaro
Copy link
Collaborator Author

kindaro commented Apr 21, 2025

Here is how it looks on the modules Test.Reference and Test.LexTree:

Reference

@jonascarpay
Copy link
Owner

Looks good, thanks. I think it would make sense to have a flag to toggle this off, though

@kindaro
Copy link
Collaborator Author

kindaro commented Apr 22, 2025

Are you sure?

Every option has a cost in ergonomics. It is another decision you delegate to your customer. If at all possible, you as the designer should make this decision for them. I do not think there are two types of customers one of which needs a white background and another light gray.  Do you think there are? I think there is only one type of customers — the type that wants the picture to be easy to understand by looking at it through standard issue human eye set.

If you find the background too dark, we can make it lighter. We can make it only a tiny shade darker than white, so that no one would even notice.

If you are sure that adding a flag is the best course of action, I shall add a flag.

@jonascarpay
Copy link
Owner

That's fair. Let's leave it in then, at least until someone requests a toggle to disable. I do think it would be good to make the color slightly lighter than this, I'll leave the choice up to you.

@kindaro
Copy link
Collaborator Author

kindaro commented Apr 22, 2025

How about this? This colour is called «white smoke».

graph

@jonascarpay
Copy link
Owner

Looks good! Let's keep track of the changes, please add something like

## Unreleased
### [Changed]
- [#49] Add background color to modules

to CHANGELOG.md, and then feel free to merge this PR yourself, I made you a maintainer

@jonascarpay jonascarpay self-requested a review April 22, 2025 10:16
kindaro added 3 commits April 23, 2025 14:44
Ideally, we want no one to even notice something changed. It should look
better but it should not register consciously. White smoke is the
lightest named shade of gray in X11 colour standard, it has 96%
lightness.
@kindaro kindaro force-pushed the feature-tinted-background branch from 2c94034 to 95c3a13 Compare April 23, 2025 07:44
@kindaro kindaro merged commit 2439f19 into jonascarpay:master Apr 23, 2025
40 checks passed
@kindaro kindaro deleted the feature-tinted-background branch April 23, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tinted module background?

2 participants