Add landscape layout feature.#47
Merged
kindaro merged 2 commits intojonascarpay:masterfrom Apr 23, 2025
Merged
Conversation
Collaborator
Author
|
Here is how it looks on the module
|
Owner
|
Looks good, thanks. Only gripe is that I find the name "landscape" confusing, since the actual aspect ratio is closer to portrait. Maybe "left-to-right" is a better name for the flag? |
Collaborator
Author
|
Yes, «left to right» is a better name. Let me rename it. |
kindaro
force-pushed
the
feature-landscape-layout
branch
2 times, most recently
from
210d1b1 to
c6e3911
Compare
Collaborator
Author
|
I renamed the flag and also changed the commit title. |
jonascarpay
approved these changes
Apr 22, 2025
Owner
jonascarpay
left a comment
jonascarpay
left a comment
There was a problem hiding this comment.
Looks good :) Let's merge #49 first, and then in this PR also add a line to the changelog
kindaro
force-pushed
the
feature-landscape-layout
branch
from
c6e3911 to
006516b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41.