initial merge b4 rebase. csr can now write to mtvec, added fence as a nop#67
Open
nganjehloo wants to merge 60 commits intomasterfrom
Open
initial merge b4 rebase. csr can now write to mtvec, added fence as a nop#67nganjehloo wants to merge 60 commits intomasterfrom
nganjehloo wants to merge 60 commits intomasterfrom
Conversation
…mments and removed some garbage code
…iles, added syscall tests
…as initialization
…nto system_csr
powerjg
reviewed
Jun 18, 2019
Contributor
powerjg
left a comment
powerjg
left a comment
There was a problem hiding this comment.
Remind me to help you learn how to rebase :). We need to clean up the commit history. There's 60 commits for 17 lines of changes!
| /* write address to trap too | ||
| */ | ||
| when (decoded_addr(MCSRs.mtvec)) { | ||
| val new_mtvec = wdata.asTypeOf(new MTVec()) |
Contributor
There was a problem hiding this comment.
Can't you just say reg_mtvec := wdata.asTypeOf(new MTVec())?
Contributor
Author
There was a problem hiding this comment.
I suppose I could. I just wanted to be explicit in case of any weird optimization trickery. Should I change it?
Collaborator
|
@nganjehloo, when you come back to this pull request make sure to place the CSR within the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a slight change to csr unit to allow a program to change the exception/trap vector (mtvec register) and added the fence instruction as a nop