Open
Conversation
* "Ignore tags older than" field was using the commit creation
date rather than the tag creation date.
* Change correctly distinguishes between:
- Annotated tags → Uses tag creation time (fixes the bug)
- Lightweight tags → Uses commit time (backward compatible)
This enables the "Ignore tags older than" feature to work correctly when new tags are created on old commits.
Fixes:
* jenkinsci#3731
* jenkinsci/basic-branch-build-strategies-plugin#268
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the "Ignore tags older than" feature was incorrectly using commit creation dates instead of tag creation dates for annotated tags. The fix introduces a new getTagTimestamp() method that properly distinguishes between annotated tags (which should use their tag creation timestamp) and lightweight tags (which should use their commit timestamp).
Changes:
- Added
getTagTimestamp()method to properly extract timestamps from both annotated and lightweight tags - Updated three call sites to use the new method instead of directly accessing commit timestamps
- Added a test to verify that tag timestamps are valid (greater than year 2000)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java | Implements the new getTagTimestamp() method and updates three locations to use it instead of directly parsing commit timestamps |
| src/test/java/jenkins/plugins/git/AbstractGitSCMSourceWantTagsTest.java | Adds basic test for tag timestamp validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing done
Submitter checklist